Discussion:
[PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI
(too old to reply)
c***@gmail.com
2018-01-29 09:22:23 UTC
Permalink
Raw Message
From: Marcus Cooper <***@gmail.com>

Add the new DAI block for I2S2 which is used for HDMI audio.

Signed-off-by: Marcus Cooper <***@gmail.com>
---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)

diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
index 7a83b15225c7..238e7007d5b9 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
@@ -568,6 +568,19 @@
status = "disabled";
};

+ i2s2: ***@1c22800 {
+ #sound-dai-cells = <0>;
+ compatible = "allwinner,sun8i-h3-i2s";
+ reg = <0x01c22800 0x400>;
+ interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&ccu CLK_BUS_I2S2>, <&ccu CLK_I2S2>;
+ clock-names = "apb", "mod";
+ dmas = <&dma 27>;
+ resets = <&ccu RST_BUS_I2S2>;
+ dma-names = "tx";
+ status = "disabled";
+ };
+
codec: ***@1c22c00 {
#sound-dai-cells = <0>;
compatible = "allwinner,sun8i-h3-codec";
--
2.16.1
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Jernej Skrabec
2018-01-29 09:35:28 UTC
Permalink
Raw Message
Hi,
Post by c***@gmail.com
Add the new DAI block for I2S2 which is used for HDMI audio.
---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
index 7a83b15225c7..238e7007d5b9 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
@@ -568,6 +568,19 @@
status = "disabled";
};
+ #sound-dai-cells = <0>;
+ compatible = "allwinner,sun8i-h3-i2s";
I think we should use separate compatible for HDMI I2S, since it supports 4
I2S lanes
contrary to i2s0 and i2s1, which support only one.

Same goes for A64 HDMI I2S.

Best regards,
Jernej
Post by c***@gmail.com
+ reg = <0x01c22800 0x400>;
+ interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&ccu CLK_BUS_I2S2>, <&ccu CLK_I2S2>;
+ clock-names = "apb", "mod";
+ dmas = <&dma 27>;
+ resets = <&ccu RST_BUS_I2S2>;
+ dma-names = "tx";
+ status = "disabled";
+ };
+
#sound-dai-cells = <0>;
compatible = "allwinner,sun8i-h3-codec";
--
2.16.1
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Code Kipper
2018-01-29 09:50:26 UTC
Permalink
Raw Message
Post by Jernej Skrabec
Hi,
Post by c***@gmail.com
Add the new DAI block for I2S2 which is used for HDMI audio.
---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
index 7a83b15225c7..238e7007d5b9 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
@@ -568,6 +568,19 @@
status = "disabled";
};
+ #sound-dai-cells = <0>;
+ compatible = "allwinner,sun8i-h3-i2s";
I think we should use separate compatible for HDMI I2S, since it supports 4
I2S lanes
contrary to i2s0 and i2s1, which support only one.
Same goes for A64 HDMI I2S.
No worries...I just had an upstream urge. I do think the other blocks
support the 4 lanes(suspicious blanking in the user manual) it just
doesn't have the pins connected.
Thanks,
CK
ps: kudos with the libreelec work...the Orange Pi 2 build that I put
together worked pretty well...I've been dreaming of this day!
Post by Jernej Skrabec
Best regards,
Jernej
Post by c***@gmail.com
+ reg = <0x01c22800 0x400>;
+ interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&ccu CLK_BUS_I2S2>, <&ccu CLK_I2S2>;
+ clock-names = "apb", "mod";
+ dmas = <&dma 27>;
+ resets = <&ccu RST_BUS_I2S2>;
+ dma-names = "tx";
+ status = "disabled";
+ };
+
#sound-dai-cells = <0>;
compatible = "allwinner,sun8i-h3-codec";
--
2.16.1
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Maxime Ripard
2018-01-29 10:22:27 UTC
Permalink
Raw Message
Post by c***@gmail.com
Add the new DAI block for I2S2 which is used for HDMI audio.
queued for 4.17, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Jernej Škrabec
2018-01-29 10:35:27 UTC
Permalink
Raw Message
Hi Maxime,

(previously I respond only to linux-sunxi mailing list)
Post by Maxime Ripard
Post by c***@gmail.com
Add the new DAI block for I2S2 which is used for HDMI audio.
queued for 4.17, thanks!
Maxime
Please note that HDMI I2S has usable 4 I2S lanes, since HDMI
supports 8 channel audio. As Marcus said, other blocks probably
support them too, they are just not wired out on pins.

Should we change compatible for HDMI?

Best regards,
Jernej
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
maxime ripard
2018-01-31 07:16:16 UTC
Permalink
Raw Message
Post by Jernej Å krabec
Hi Maxime,
(previously I respond only to linux-sunxi mailing list)
Post by Maxime Ripard
Post by c***@gmail.com
Add the new DAI block for I2S2 which is used for HDMI audio.
queued for 4.17, thanks!
Maxime
Please note that HDMI I2S has usable 4 I2S lanes, since HDMI
supports 8 channel audio. As Marcus said, other blocks probably
support them too, they are just not wired out on pins.
I've dropped those patches for now.
Post by Jernej Å krabec
Should we change compatible for HDMI?
I guess, another way of doing things if they are strictly identical
but for the number of lanes they support would be to add a DT property
for that number of lanes.

Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Code Kipper
2018-01-31 09:54:29 UTC
Permalink
Raw Message
On 31 January 2018 at 08:16, maxime ripard
Post by maxime ripard
Post by Jernej Å krabec
Hi Maxime,
(previously I respond only to linux-sunxi mailing list)
Post by Maxime Ripard
Post by c***@gmail.com
Add the new DAI block for I2S2 which is used for HDMI audio.
queued for 4.17, thanks!
Maxime
Please note that HDMI I2S has usable 4 I2S lanes, since HDMI
supports 8 channel audio. As Marcus said, other blocks probably
support them too, they are just not wired out on pins.
I've dropped those patches for now.
Post by Jernej Å krabec
Should we change compatible for HDMI?
I guess, another way of doing things if they are strictly identical
but for the number of lanes they support would be to add a DT property
for that number of lanes.
That's fine...I'll look into adding a dt property and how we would map
channels to lanes.
Do you know of any examples?,
BR,
CK
Post by maxime ripard
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
maxime ripard
2018-01-31 15:57:51 UTC
Permalink
Raw Message
Post by Code Kipper
On 31 January 2018 at 08:16, maxime ripard
Post by maxime ripard
Post by Jernej Å krabec
Hi Maxime,
(previously I respond only to linux-sunxi mailing list)
Post by Maxime Ripard
Post by c***@gmail.com
Add the new DAI block for I2S2 which is used for HDMI audio.
queued for 4.17, thanks!
Maxime
Please note that HDMI I2S has usable 4 I2S lanes, since HDMI
supports 8 channel audio. As Marcus said, other blocks probably
support them too, they are just not wired out on pins.
I've dropped those patches for now.
Post by Jernej Å krabec
Should we change compatible for HDMI?
I guess, another way of doing things if they are strictly identical
but for the number of lanes they support would be to add a DT property
for that number of lanes.
That's fine...I'll look into adding a dt property and how we would map
channels to lanes.
Do you know of any examples?,
Grepping for of_property_read_u32 should give you plenty of examples :)

maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Loading...