Discussion:
[PATCH] sunxi: add MACPWR in Orange Pi PC2 defconfig
Add Reply
Icenowy Zheng
2017-07-04 10:43:11 UTC
Reply
Permalink
Raw Message
The Ethernet function is enabled in the Orange Pi PC2 device tree and
defconfig, however, CONFIG_MACPWR is not properly set, which left the
PHY being disabled when booting, which makes the Ethernet function not
usable.

Add the proper value of this option in the PC2 defconfig.

Fixes: e7bd15ea156f ("sunxi: Add OrangePi PC 2 initial support")
Signed-off-by: Icenowy Zheng <***@aosc.io>
---
configs/orangepi_pc2_defconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/configs/orangepi_pc2_defconfig b/configs/orangepi_pc2_defconfig
index 5a64ad3f41..b72514d3b9 100644
--- a/configs/orangepi_pc2_defconfig
+++ b/configs/orangepi_pc2_defconfig
@@ -4,6 +4,7 @@ CONFIG_SPL_SPI_FLASH_SUPPORT=y
CONFIG_MACH_SUN50I_H5=y
CONFIG_DRAM_CLK=672
CONFIG_DRAM_ZQ=3881977
+CONFIG_MACPWR="PD6"
CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-pc2"
# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
CONFIG_SPL=y
--
2.13.0
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Andre Przywara
2017-07-04 10:47:17 UTC
Reply
Permalink
Raw Message
Hi,
Post by Icenowy Zheng
The Ethernet function is enabled in the Orange Pi PC2 device tree and
defconfig, however, CONFIG_MACPWR is not properly set, which left the
PHY being disabled when booting, which makes the Ethernet function not
usable.
Indeed, so I can remove this very same patch from my queue here ;-)
Post by Icenowy Zheng
Add the proper value of this option in the PC2 defconfig.
Fixes: e7bd15ea156f ("sunxi: Add OrangePi PC 2 initial support")
I believe the support for CONFIG_MACPWR wasn't there when I wrote this
patch, so I hacked this into my ATF port at the time ;-)
Acked-by: Andre Przywara <***@arm.com>

Thanks,
Andre.
Post by Icenowy Zheng
---
configs/orangepi_pc2_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/orangepi_pc2_defconfig b/configs/orangepi_pc2_defconfig
index 5a64ad3f41..b72514d3b9 100644
--- a/configs/orangepi_pc2_defconfig
+++ b/configs/orangepi_pc2_defconfig
@@ -4,6 +4,7 @@ CONFIG_SPL_SPI_FLASH_SUPPORT=y
CONFIG_MACH_SUN50I_H5=y
CONFIG_DRAM_CLK=672
CONFIG_DRAM_ZQ=3881977
+CONFIG_MACPWR="PD6"
CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-pc2"
# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
CONFIG_SPL=y
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Icenowy Zheng
2017-07-04 10:48:37 UTC
Reply
Permalink
Raw Message
Post by Andre Przywara
Hi,
Post by Icenowy Zheng
The Ethernet function is enabled in the Orange Pi PC2 device tree and
defconfig, however, CONFIG_MACPWR is not properly set, which left the
PHY being disabled when booting, which makes the Ethernet function
not
Post by Icenowy Zheng
usable.
Indeed, so I can remove this very same patch from my queue here ;-)
Post by Icenowy Zheng
Add the proper value of this option in the PC2 defconfig.
Fixes: e7bd15ea156f ("sunxi: Add OrangePi PC 2 initial support")
I believe the support for CONFIG_MACPWR wasn't there when I wrote this
patch, so I hacked this into my ATF port at the time ;-)
It used to be in CONFIG_EXTRA_OPTIONS, see the history of
H3 GbE OPis' defconfig.
Post by Andre Przywara
Thanks,
Andre.
Post by Icenowy Zheng
---
configs/orangepi_pc2_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/orangepi_pc2_defconfig
b/configs/orangepi_pc2_defconfig
Post by Icenowy Zheng
index 5a64ad3f41..b72514d3b9 100644
--- a/configs/orangepi_pc2_defconfig
+++ b/configs/orangepi_pc2_defconfig
@@ -4,6 +4,7 @@ CONFIG_SPL_SPI_FLASH_SUPPORT=y
CONFIG_MACH_SUN50I_H5=y
CONFIG_DRAM_CLK=672
CONFIG_DRAM_ZQ=3881977
+CONFIG_MACPWR="PD6"
CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-pc2"
# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
CONFIG_SPL=y
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Andre Przywara
2017-07-04 10:52:33 UTC
Reply
Permalink
Raw Message
Hi,
Post by Icenowy Zheng
Post by Andre Przywara
Hi,
Post by Icenowy Zheng
The Ethernet function is enabled in the Orange Pi PC2 device tree and
defconfig, however, CONFIG_MACPWR is not properly set, which left the
PHY being disabled when booting, which makes the Ethernet function
not
Post by Icenowy Zheng
usable.
Indeed, so I can remove this very same patch from my queue here ;-)
Post by Icenowy Zheng
Add the proper value of this option in the PC2 defconfig.
Fixes: e7bd15ea156f ("sunxi: Add OrangePi PC 2 initial support")
I believe the support for CONFIG_MACPWR wasn't there when I wrote this
patch, so I hacked this into my ATF port at the time ;-)
It used to be in CONFIG_EXTRA_OPTIONS, see the history of
H3 GbE OPis' defconfig.
I know, but I didn't want to let this legacy hack creep into a new board.

Cheers,
Andre.
Post by Icenowy Zheng
Post by Andre Przywara
Thanks,
Andre.
Post by Icenowy Zheng
---
configs/orangepi_pc2_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/orangepi_pc2_defconfig
b/configs/orangepi_pc2_defconfig
Post by Icenowy Zheng
index 5a64ad3f41..b72514d3b9 100644
--- a/configs/orangepi_pc2_defconfig
+++ b/configs/orangepi_pc2_defconfig
@@ -4,6 +4,7 @@ CONFIG_SPL_SPI_FLASH_SUPPORT=y
CONFIG_MACH_SUN50I_H5=y
CONFIG_DRAM_CLK=672
CONFIG_DRAM_ZQ=3881977
+CONFIG_MACPWR="PD6"
CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-pc2"
# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
CONFIG_SPL=y
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Loading...